[HaikuPorts-svn] haikuports : 3 new changesets : 08db06dc07dc

[Jonathan Schleifer]

Am 29.03.2014 um 11:58 schrieb Adrien Destugues <haikuports-svn at lists.ports.haiku-files.org>:

> +DESCRIPTION="Based on BinaryClock by David Enderson Uses filled rectangles and random colors."

Seems like punctuation is missing here.

> +COPYRIGHT="2012 Jim Saxton, Fat Elk Softrware"

I doubt it's really named "Softrware" ;).

> +BUILD()
> +
> +{

That empty line shouldn't be there.

> -#SOURCE_DIR="DigiClock-$portVersion"
> +#SOURCE_DIR="digiclock-$portVersion"

Why change this if this isn't even used? Maybe it's better to just remove it?

> PROVIDES="
> 
> -DigiClock = 1.0"
> +app:digiclock = $portVersion"

That empty line shouldn't be there.

Also, I think you should always provide $portName = $portVersion.

> BUILD_REQUIRES="
> 	haiku${secondaryArchSuffix}_devel >= $haikuVersion
> -	cmd:gcc$secondaryArchSuffix
> -	cmd:make
> -	makefile_engine"
> +	"

While it's correct that you remove them here …

> BUILD_PREREQUIRES="
> 	cmd:gcc$secondaryArchSuffix

… you should list them here. Unless make really isn't used.

Also, can you *please* fold (if it makes sense, like in this case) and rebase before merging? This makes reviewing diffs 10 times more work than it needs to be, thus wastes everybody's time, *and* spams the repository.

--
Jonathan